Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix console warning in the test #16266

Closed
wants to merge 1 commit into from
Closed

[test] Fix console warning in the test #16266

wants to merge 1 commit into from

Conversation

arminmeh
Copy link
Contributor

Missing rowCount in the initial state might be throwing warnings and breaking tests with React 18.
The exact same test with the treeData and rowCount in the initial state works just fine.

@arminmeh arminmeh added test component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Jan 20, 2025
@mui-bot
Copy link

mui-bot commented Jan 20, 2025

Deploy preview: https://deploy-preview-16266--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fa1b42d

@arminmeh arminmeh closed this Jan 20, 2025
@arminmeh arminmeh deleted the fix-test branch January 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy Awaiting requested review from LukasTy

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge test v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arminmeh @mui-bot